Skip to content

feat(node): Support IPv6 as DSN (#2996) #17708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −2
Open

feat(node): Support IPv6 as DSN (#2996) #17708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b92a7a1
feat(node): Support IPv6 as DSN (#2996)
xgedev Sep 19, 2025
d9e6e74
style(node): Resolve warns shown by "yarn lint"
xgedev Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/utils/dsn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { consoleSandbox, debug } from './debug-logger';
const ORG_ID_REGEX = /^o(\d+)\./;

/** Regular expression used to parse a Dsn. */
const DSN_REGEX = /^(?:(\w+):)\/\/(?:(\w+)(?::(\w+)?)?@)([\w.-]+)(?::(\d+))?\/(.+)/;
const DSN_REGEX = /^(?:(\w+):)\/\/(?:(\w+)(?::(\w+)?)?@)((?:\[[0-9a-fA-F:]+\]|[\w.-]+))(?::(\d+))?\/(.+)/;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: IPv6 DSN Parsing Fails for Mapped Addresses

The DSN_REGEX update for IPv6 addresses is too restrictive. The IPv6 host pattern [0-9a-fA-F:]+ is missing dots for IPv4-mapped IPv6 addresses and percent signs for zone identifiers, causing valid DSNs with these formats to fail parsing.

Fix in Cursor Fix in Web


function isValidProtocol(protocol?: string): protocol is DsnProtocol {
return protocol === 'http' || protocol === 'https';
Expand Down
5 changes: 4 additions & 1 deletion packages/node-core/src/transports/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,15 @@ function createRequestExecutor(
body = body.pipe(createGzip());
}

const hostnameIsIPv6 = hostname.startsWith('[');

const req = httpModule.request(
{
method: 'POST',
agent,
headers,
hostname,
// Remove "[" and "]" from IPv6 hostnames
hostname: hostnameIsIPv6 ? hostname.slice(1, -1) : hostname,
path: `${pathname}${search}`,
port,
protocol,
Expand Down
Loading