Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 25, 2025

this is actually a fix but not a user-facing one, therefore, ref.

Starting with 1.14.3, import-in-the-middle uses both, import and require statements in its hook.mjs file. This caused @vercel/nft in its default config to not trace the required hook.js file (+ all of its dependencies). This PR enables mixedModules: true to trace both, requires and imports. In contrast to #17777, we therefore don't have to override the IITM version and we also don't have to revert this PR.

Copy link
Contributor

github-actions bot commented Sep 25, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.26 kB - -
@sentry/browser - with treeshaking flags 22.77 kB - -
@sentry/browser (incl. Tracing) 40.43 kB - -
@sentry/browser (incl. Tracing, Replay) 78.81 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.48 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 83.48 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 95.69 kB - -
@sentry/browser (incl. Feedback) 40.97 kB - -
@sentry/browser (incl. sendFeedback) 28.91 kB - -
@sentry/browser (incl. FeedbackAsync) 33.84 kB - -
@sentry/react 25.98 kB - -
@sentry/react (incl. Tracing) 42.41 kB - -
@sentry/vue 28.78 kB - -
@sentry/vue (incl. Tracing) 42.24 kB - -
@sentry/svelte 24.29 kB - -
CDN Bundle 25.77 kB - -
CDN Bundle (incl. Tracing) 40.33 kB - -
CDN Bundle (incl. Tracing, Replay) 76.56 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 82.05 kB - -
CDN Bundle - uncompressed 75.37 kB - -
CDN Bundle (incl. Tracing) - uncompressed 119.39 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 234.51 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 247.27 kB - -
@sentry/nextjs (client) 44.42 kB - -
@sentry/sveltekit (client) 40.85 kB - -
@sentry/node-core 50.02 kB - -
@sentry/node 152.83 kB -0.25% -375 B 🔽
@sentry/node - without tracing 91.94 kB - -
@sentry/aws-serverless 105.39 kB - -

View base workflow run

@Lms24 Lms24 self-assigned this Sep 25, 2025
@Lms24 Lms24 merged commit 4df0621 into develop Sep 25, 2025
40 checks passed
@Lms24 Lms24 deleted the lms/ref-aws-serverless-fix-nft branch September 25, 2025 11:19
@Lms24 Lms24 changed the title ref(aws-serverless): Add resolution for import-in-the-middle when building the Lambda layer ref(aws-serverless): Ensure all import-in-the-middle code is added to the Lambda layer Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants