Skip to content

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 2, 2025

https://www.w3.org/TR/baggage/#example contains an example where properties can include an =, e.g. key3=value3; propertyKey=propertyValue

This PR updates our baggage parsing to not swallow these property values

closes #17845

@chargome chargome self-assigned this Oct 2, 2025
@chargome chargome requested review from Lms24 and andreiborza October 2, 2025 09:43
Copy link
Contributor

github-actions bot commented Oct 2, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.26 kB +0.11% +25 B 🔺
@sentry/browser - with treeshaking flags 22.77 kB +0.11% +23 B 🔺
@sentry/browser (incl. Tracing) 40.45 kB +0.06% +22 B 🔺
@sentry/browser (incl. Tracing, Replay) 78.83 kB +0.04% +24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.47 kB +0.04% +23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 83.5 kB +0.04% +26 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 95.69 kB +0.03% +22 B 🔺
@sentry/browser (incl. Feedback) 40.97 kB +0.06% +22 B 🔺
@sentry/browser (incl. sendFeedback) 28.91 kB +0.1% +27 B 🔺
@sentry/browser (incl. FeedbackAsync) 33.85 kB +0.08% +26 B 🔺
@sentry/react 25.98 kB +0.08% +19 B 🔺
@sentry/react (incl. Tracing) 42.42 kB +0.06% +24 B 🔺
@sentry/vue 28.77 kB +0.09% +23 B 🔺
@sentry/vue (incl. Tracing) 42.26 kB +0.07% +27 B 🔺
@sentry/svelte 24.29 kB +0.1% +24 B 🔺
CDN Bundle 25.77 kB +0.09% +21 B 🔺
CDN Bundle (incl. Tracing) 40.33 kB +0.06% +22 B 🔺
CDN Bundle (incl. Tracing, Replay) 76.58 kB +0.04% +27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 82.08 kB +0.03% +20 B 🔺
CDN Bundle - uncompressed 75.35 kB +0.08% +56 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 119.36 kB +0.05% +56 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 234.52 kB +0.03% +56 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 247.28 kB +0.03% +56 B 🔺
@sentry/nextjs (client) 44.42 kB +0.06% +23 B 🔺
@sentry/sveltekit (client) 40.87 kB +0.07% +26 B 🔺
@sentry/node-core 50.49 kB +0.05% +22 B 🔺
@sentry/node 154.11 kB +0.02% +19 B 🔺
@sentry/node - without tracing 92.33 kB +0.01% +9 B 🔺
@sentry/aws-serverless 106.05 kB +0.02% +20 B 🔺

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!
Could you add or adjust one of the browser integration tests as well? I believe we already have a test that shows how we deal with 3rd party baggage values but it doesn't include the more complex entries with properties.

Copy link
Contributor

github-actions bot commented Oct 2, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,828 - 8,960 -1%
GET With Sentry 1,345 15% 1,359 -1%
GET With Sentry (error only) 5,945 67% 5,987 -1%
POST Baseline 1,188 - 1,189 -0%
POST With Sentry 502 42% 495 +1%
POST With Sentry (error only) 1,055 89% 1,056 -0%
MYSQL Baseline 3,270 - 3,283 -0%
MYSQL With Sentry 407 12% 410 -1%
MYSQL With Sentry (error only) 2,662 81% 2,663 -0%

View base workflow run

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chargome chargome merged commit 51a9def into develop Oct 2, 2025
189 of 190 checks passed
@chargome chargome deleted the cg-baggage-header-property-values branch October 2, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baggage header propagation is dropping property values
2 participants