Skip to content

Conversation

AbhiPrasad
Copy link
Member

This package was added in #16652, but with the merge of #17584 we can remove it. We will recommend users use the pinoIntegration because it's way easier to set up and tracing works ootb.

This package was never published (no craft config) so it's safe to remove.

@AbhiPrasad AbhiPrasad requested review from timfish and a team October 2, 2025 14:00
@AbhiPrasad AbhiPrasad self-assigned this Oct 2, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and s1gr1d and removed request for a team October 2, 2025 14:00
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Copy link
Contributor

github-actions bot commented Oct 2, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,720 - 9,104 -4%
GET With Sentry 1,322 15% 1,368 -3%
GET With Sentry (error only) 5,958 68% 5,991 -1%
POST Baseline 1,161 - 1,193 -3%
POST With Sentry 496 43% 503 -1%
POST With Sentry (error only) 1,033 89% 1,054 -2%
MYSQL Baseline 3,288 - 3,254 +1%
MYSQL With Sentry 363 11% 425 -15%
MYSQL With Sentry (error only) 2,638 80% 2,692 -2%

View base workflow run

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 2, 2025 14:27
@AbhiPrasad AbhiPrasad merged commit 632f0b9 into develop Oct 2, 2025
188 of 189 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-pino-transport-package branch October 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants