Skip to content

fix: DOMError and DOMException should be error level events #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

fix: DOMError and DOMException should be error level events #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- [browser] fix: DOMError and DOMException should be error level events
- [utils] ref: Update wrap method to hide internal sentry flags
- [utils] fix: Make internal Sentry flags non-enumerable in fill util

Expand Down
2 changes: 1 addition & 1 deletion packages/browser/src/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
const name = ex.name || (isDOMError(ex) ? 'DOMError' : 'DOMException');
const message = ex.message ? `${name}: ${ex.message}` : name;

event = await this.eventFromMessage(message, undefined, hint);
event = await this.eventFromMessage(message, Severity.Error, hint);
addExceptionTypeValue(event, message);
} else if (isError(exception as Error)) {
// we have a real Error object, do nothing
Expand Down