Skip to content

feat: Add flush & close and dsn from process for node #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 14, 2019

No description provided.

@HazAT HazAT self-assigned this Feb 14, 2019
@HazAT HazAT requested a review from kamilogorek as a code owner February 14, 2019 10:04
@HazAT HazAT changed the title feat: Add flush close and dsn from process for node feat: Add flush & close and dsn from process for node Feb 14, 2019
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 14, 2019

Messages
📖 ✅ TSLint passed
📖 @sentry/browser gzip'ed minified size: 22.0273 kB

Generated by 🚫 dangerJS

@kamilogorek
Copy link
Contributor

I think we should expose flush/close on the browser as well. Just to be inline with node and give users a way to wait for the response (eg. in electron's renderer process or some mobile solutions).
Other than this 👍

@HazAT HazAT force-pushed the feat/dsn-and-flush branch from 84fa08f to 59ce631 Compare February 14, 2019 12:17
@HazAT HazAT force-pushed the feat/dsn-and-flush branch from 59ce631 to 4b3b39f Compare February 14, 2019 12:19
@HazAT HazAT merged commit f6fc304 into master Feb 14, 2019
@HazAT HazAT deleted the feat/dsn-and-flush branch February 14, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants