Clarify that Raven.context rethrows exceptions #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs don't currently make it clear that an exception will be thrown again after Raven.context records it. (This does raise a side question of whether it'd be useful to have a helper which absorbs caught exceptions to reduce the need for try / catch blocks all over the place)
mattrobenolt
added a commit
that referenced
this pull request
Feb 25, 2014
Clarify that Raven.context rethrows exceptions
|
The behavior is such so that it's transparent. Your app is still in charge of handling it's own exceptions. If an uncaught exception goes by without being raised, that may cause undesirable results in your application. So we just log it, then re-raise to maintain existing behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs don't currently make it clear that an exception will be thrown again after Raven.context records it.
(This does raise a side question of whether it'd be useful to have a helper which absorbs caught exceptions to reduce the need for try / catch blocks all over the place)