fix: Wait for processing to finish before closing transport #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
reviewed
Apr 10, 2019
packages/core/src/baseclient.ts
Outdated
| @@ -58,6 +58,9 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement | |||
| /** Is the client still processing a call? */ | |||
| protected _processing: boolean = false; | |||
|
|
|||
| /** Processing interval */ | |||
| protected _processingInterval?: NodeJS.Timeout; | |||
There was a problem hiding this comment.
I'm not sure if this will be available in browser environments, which may cause same issus as with getCurrentHub and Window
|
I'm not sure about the performance implications of this change, but the implementation looks fine |
|
So I agree, but considering this only ever applies if you call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2000
There was an issue with flush that we have to wait for processing of the client to finish first before we ask the transport to drain.
cc @sheerun thanks for pointing this out