Fix: Don't overwrite the transaction on an event if it's already been set. #2129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the transaction property being overwritten if it has already been set on the event.
v5.2.0 saw the introduction of the
setTransaction
function on the scopes . The value set using this function in@sentry/node
isn't being respected currently.Setting the transaction in
@sentry/browser
works fine.Example issue
When I inspect the current scope after I've used the
scope.setTransaction
call I can see the transaction is set correctly, however if I check the event in thebeforeSend
callback it's been changed.Transaction value from the current scope before submitting an error
Transaction value from
beforeSend
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).