Skip to content

fix: When using enabled:false integrations shouldnt be installed #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019
Merged

fix: When using enabled:false integrations shouldnt be installed #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/baseclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
protected readonly _dsn?: Dsn;

/** Array of used integrations. */
protected readonly _integrations: IntegrationIndex;
protected readonly _integrations: IntegrationIndex = {};

/** Is the client still processing a call? */
protected _processing: boolean = false;
Expand All @@ -72,7 +72,9 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
this._dsn = new Dsn(options.dsn);
}

this._integrations = setupIntegrations(this._options);
if (!options.enabled) {
this._integrations = setupIntegrations(this._options);
}
}

/**
Expand Down