Skip to content

ref: Deprecate top-level stacktrace #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2019
Merged

ref: Deprecate top-level stacktrace #2214

merged 2 commits into from
Aug 29, 2019
+214 −59

Conversation

kamilogorek
Copy link
Contributor

image

@kamilogorek kamilogorek requested a review from HazAT August 26, 2019 10:06
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Aug 26, 2019 •
edited
Loading

Fails
🚫

TSLint failed: @sentry/core
🚫

TSLint failed: @sentry/integrations
Messages
📖

@sentry/browser bundle gzip'ed minified size: ($ cat build/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print "ES5: ",$1,"kB";}') (ES5: 16.2051 kB)

Generated by 🚫 dangerJS against d93aa12

@kamilogorek kamilogorek force-pushed the deprecate-stacktrace branch from 7f61956 to f1fdc70 Compare August 26, 2019 10:21
@HazAT
Copy link
Member

HazAT commented Aug 26, 2019

@jan-auer Probably not you but can we tell the Sentry UI to not show the thread selector in case of only one thread?
Some ppl will find this strange in JS.

HazAT
HazAT requested changes Aug 26, 2019
View reviewed changes
packages/types/src/event.ts
@@ -33,6 +34,7 @@ export interface Event {
extra?: { [key: string]: any };
user?: User;
type?: EventType;
threads?: Thread[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a @deprecated Use event.threads.0.stacktrace comment to stacktrace.

packages/core/src/baseclient.ts Outdated
@@ -371,6 +371,12 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
return;
}

if ('stacktrace' in finalEvent) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this, just bloats up the bundle size.
If we deprecate the property in TS in the type it's enough.

@jan-auer
Copy link
Member

@HazAT @kamilogorek can you test with this please?
getsentry/sentry#14503

@kamilogorek kamilogorek force-pushed the deprecate-stacktrace branch from f1fdc70 to d93aa12 Compare August 27, 2019 12:34
@kamilogorek
Copy link
Contributor Author

@HazAT done

image

@kamilogorek kamilogorek force-pushed the deprecate-stacktrace branch from 20ea674 to 7d995cb Compare August 29, 2019 11:58
@kamilogorek kamilogorek merged commit 36d206c into master Aug 29, 2019
@kamilogorek kamilogorek deleted the deprecate-stacktrace branch August 29, 2019 12:01
@kamilogorek kamilogorek restored the deprecate-stacktrace branch August 29, 2019 12:52
kamilogorek added a commit that referenced this pull request Aug 29, 2019
@kamilogorek
Revert "ref: Deprecate top-level stacktrace (#2214)"
76644bf 
This reverts commit 36d206c.
@kamilogorek kamilogorek deleted the deprecate-stacktrace branch October 21, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilogorek @getsentry-bot @HazAT @jan-auer