feat: Refactor breadcrumbs integration to allow for custom handlers #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
intrumentation-handlers
branch
from
262f201 to
4b898f9
Compare
kamilogorek
force-pushed
the
intrumentation-handlers
branch
from
4b898f9 to
d9fd340
Compare
HazAT
reviewed
Nov 15, 2019
| @@ -1,23 +1,23 @@ | |||
| // TODO: Rename this whole file to `instrument.ts` and make a distinction between instrumenting (wrapping the API) | |||
There was a problem hiding this comment.
Let’s mark it as deprecated, so we can remove it with v6
| // [key in InstrumentHandlerType]?: boolean; | ||
|
|
||
| /** JSDoc */ | ||
| interface BreadcrumbIntegrations { |
There was a problem hiding this comment.
Also, add depreate here, the name should become something like, InstrumentOptions
HazAT
reviewed
Nov 15, 2019
Comment on lines
33
to
35
| // Dynamic keys like the one below doesn't work with interfaces :( | ||
| // [key in InstrumentHandlerType]?: boolean; | ||
|
|
|
does this fix #2125? |
|
Not yet, sorry https://github.com/getsentry/sentry-javascript/pull/2317/files#diff-8ac38be8ae7b14923c24ee27c747794cR194-R199 In order to unify dom breadcrumbs as well, this has to be corrected - #2299 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.