Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Move global error handler+ promise rejection #2475

Merged
merged 2 commits into from
Mar 9, 2020
Merged

ref: Move global error handler+ promise rejection #2475

merged 2 commits into from
Mar 9, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 6, 2020 •
edited
Loading

We need this to mark a transaction as failed if a global unhandled error occurs.

I couldn't move to addEventListener since it doesn't work well with the loader.

@HazAT HazAT requested a review from kamilogorek as a code owner March 6, 2020 12:49
@HazAT HazAT self-assigned this Mar 6, 2020
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Mar 6, 2020 •
edited
Loading

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7412 kB) (ES6: 15.7559 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 029ed99

kamilogorek
kamilogorek approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@HazAT
Copy link
Member Author

HazAT commented Mar 9, 2020

In our tests I trust

@HazAT HazAT merged commit dd7bf92 into master Mar 9, 2020
@HazAT HazAT deleted the ref-globalerror-promise branch March 9, 2020 10:26
This was referenced Mar 14, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Apr 2, 2020
Merged
Merged
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Open
This was referenced Apr 22, 2020
Closed
Closed
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
@dan-dr dan-dr mentioned this pull request Jan 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazAT @getsentry-bot @kamilogorek