fix: sent_at for envelope headers #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
May 18, 2020
| event_id: event.event_id, | ||
| sent_at: new Date().toISOString(), | ||
| // We need to add * 1000 since we devide it by 1000 by default but JS works with ms precision | ||
| // The reason we use timestampWithMs here is that all clocks across the SDK use the same clock |
There was a problem hiding this comment.
Rather than saying that all clocks are the same, maybe mention something about the performance API?
There was a problem hiding this comment.
I rather not, maybe we drop the usage of performance API.
We use timestampWithMs everywhere and we should also here.
Sija
reviewed
May 18, 2020
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Co-authored-by: Abhijeet Prasad <AbhiPrasad@users.noreply.github.com>
rhcarvalho
approved these changes
May 18, 2020
There was a problem hiding this comment.
This will make some browser instances set sent_at to wildly wrong values as we've found in #2590.
With the changes to collect more debug info in #2588, and changes to timestamp correction in Relay, we can give this a shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
sent_atheader in the envelope to use the same clock as everywhere else.