Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pageload transaction option + fixes #2623

Merged
merged 3 commits into from
May 28, 2020
Merged

feat: Add pageload transaction option + fixes #2623

merged 3 commits into from
May 28, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented May 28, 2020

  • Removes span.sampled from payload
  • Adds new option to Tracing Integration startTransactionOnPageLoad
  • Fixes a bug with discarding all spans of pageload transaction
  • Adds a feature that if the user navigates to before all spans are finished on the page, we finish the span and set status to cancelled

@HazAT HazAT requested a review from kamilogorek as a code owner May 28, 2020 09:19
@HazAT HazAT self-assigned this May 28, 2020
@HazAT HazAT merged commit f14ec02 into master May 28, 2020
@HazAT HazAT deleted the hazat/fix-tracing-integration branch May 28, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HazAT @kamilogorek