misc: Add note regarding fetch API rethrow #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 14, 2020
| @@ -169,6 +169,9 @@ function instrumentFetch(): void { | |||
| endTimestamp: Date.now(), | |||
| error, | |||
| }); | |||
| // NOTE: If you are a Sentry user, and you are seeing this stack frame, | |||
| // it means the sentry.javascript SDK caught an error invoking your application code. | |||
| // This is expected behavior and NOT indicative of a bug with sentry.javascript. | |||
There was a problem hiding this comment.
I wouldn’t say this is “expected behaviour”
There was a problem hiding this comment.
It is in the SDK itself though. We have the exact same note in 2 different places (browser/src/helpers.ts) since raven.js times 😅
AbhiPrasad
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.