Skip to content

build: Run Zeus for release/ branches only #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

kamilogorek
Copy link
Contributor

  • run Zeus for release/ branches only
  • move artifacts upload higher on the list so that conditional steps are always last
  1. Why do we run upload artifacts at all anyway? Do we need it every time?
  2. Should we use the same if check for BrowserStack? Not sure why we use tag there

@kamilogorek kamilogorek requested a review from HazAT August 23, 2020 11:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (0%)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.69 KB (-0.34% 🔽)

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is only relevant in the UI, moving the job does nothing, only this tells the job to run after another one needs: job_build.

I would say we also could move if: "contains(github.ref, 'release/')" to the job_artifacts since this is already preparing for replacing zeus and only runs there.

@kamilogorek kamilogorek merged commit caff9e7 into master Aug 24, 2020
@kamilogorek kamilogorek deleted the zeus-release-only branch August 24, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants