chore(build): Upgrade prettier #2850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
kamilogorek
approved these changes
Aug 27, 2020
|
I'll merge this to prepare a release |
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of
prettierprior to1.19.0didn't include support for new features introduced in TS 3.7 like optional chaining. So that using those features doesn't break CI builds, this upgradesprettierto that version. (We probably want to consider upgrading further, but for the moment this is an easy change which will unblock PRs.)No breaking changes are listed in either the 1.18.0 release notes or the 1.19.0 release notes, and I have confirmed that after running
yarn fixfor the whole repo,yarn lint,yarn build, andyarn testall run with no errors.