New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integerations/Offline: Remove false positive #2890

Merged

kamilogorek merged 2 commits into getsentry:master from piotr-cz:cs/remove-false-positive

Sep 14, 2020

Contributor

piotr-cz commented Sep 10, 2020

The Hub.captureEvent method always returns new event ID, so event will always be purged from event store (even that client failed to send it).

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).


          Remove false positive

202c480

piotr-cz requested a review from kamilogorek as a code owner

September 10, 2020 09:13

piotr-cz mentioned this pull request

Add integration for offline support #2778

Merged

2 tasks


          Merge branch 'master' into cs/remove-false-positive

8f6a2a9

kamilogorek merged commit 15465a8 into getsentry:master

Contributor

kamilogorek commented Sep 14, 2020

Thanks!

piotr-cz deleted the cs/remove-false-positive branch

September 14, 2020 12:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment