Skip to content

fix: Make Vue tracing options optional #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020
Merged

fix: Make Vue tracing options optional #2897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f474c74
fix: Typo
hadalin Sep 14, 2020
acfbce7
fix: Make Vue tracing options optional
hadalin Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/integrations/src/vue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ export class Vue implements Integration {
/**
* @inheritDoc
*/
public constructor(options: Partial<IntegrationOptions>) {
public constructor(
options: Partial<Omit<IntegrationOptions, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }>,
) {
this._options = {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
Vue: getGlobalObject<any>().Vue,
Expand Down Expand Up @@ -313,7 +315,7 @@ export class Vue implements Integration {
}
};

// Each compomnent has it's own scope, so all activities are only related to one of them
// Each component has it's own scope, so all activities are only related to one of them
this._options.tracingOptions.hooks.forEach(operation => {
// Retrieve corresponding hooks from Vue lifecycle.
// eg. mount => ['beforeMount', 'mounted']
Expand Down