Skip to content

fix(web-vitals): Only report FCP or FP if the page wasn't hidden prior to their instrumentation #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

fix(web-vitals): Only report FCP or FP if the page wasn't hidden prior to their instrumentation #2979

merged 1 commit into from
Oct 19, 2020

Conversation

dashed
Copy link
Member

@dashed dashed commented Oct 16, 2020

@dashed dashed requested review from a team October 16, 2020 20:56
@dashed dashed requested a review from kamilogorek as a code owner October 16, 2020 20:56
@dashed dashed self-assigned this Oct 16, 2020
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.59 KB (0%)
@sentry/browser - Webpack 20.42 KB (0%)
@sentry/react - Webpack 20.42 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.38 KB (+0.07% 🔺)

@dashed dashed merged commit 86ca835 into master Oct 19, 2020
@dashed dashed deleted the record-fcp-before-hidden branch October 19, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dashed dashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashed @kamilogorek