Skip to content

Conversation

kamilogorek
Copy link
Contributor

This takes time to finish https://github.com/mshanfard/sentry-debug (repro case) test suite from 54s to 14s. Without Sentry it's ~9-10s.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.65 KB (+0.09% 🔺)
@sentry/browser - Webpack 20.51 KB (+0.16% 🔺)
@sentry/react - Webpack 20.51 KB (+0.16% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.64 KB (+0.06% 🔺)

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lobsterkatie lobsterkatie changed the title fix: Dont call removeEventListener for functions that were not wrapped fix(browser): Call removeEventListener twice only when necessary Oct 30, 2020
@lobsterkatie lobsterkatie merged commit 8489072 into master Oct 30, 2020
@lobsterkatie lobsterkatie deleted the fix-dont-remove-unnecessary-listeners branch October 30, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants