feat: Prepare Major Release / Toggle session tracking flag #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatsby/Ember/Angular/React/Vue
size-limit report
|
kamilogorek
reviewed
Dec 3, 2020
packages/ember/addon/index.ts
Outdated
| @@ -17,6 +17,9 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) { | |||
| assert('Missing configuration for Sentry.', config.sentry); | |||
|
|
|||
| const initConfig = Object.assign({}, config.sentry, _runtimeConfig || {}); | |||
| if (initConfig.autoSessionTracking === undefined) { | |||
There was a problem hiding this comment.
This is unnecessary, as we call Sentry.init which already does that 3 lines below.
kamilogorek
reviewed
Dec 3, 2020
packages/vue/src/sdk.ts
Outdated
| @@ -132,6 +132,9 @@ export function init( | |||
| if (options.defaultIntegrations === undefined) { | |||
| options.defaultIntegrations = defaultIntegrations; | |||
| } | |||
| if (options.autoSessionTracking === undefined) { | |||
There was a problem hiding this comment.
I wonder why we call Sentry.init in Ember, but not in Vue
There was a problem hiding this comment.
In Vue.js we overwrite init to initialize the helper.
kamilogorek
approved these changes
Jan 12, 2021
kamilogorek
approved these changes
Jan 18, 2021
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes session tracking / release health enabled by default for all frontend SDKs.
After this is merged we need to prepare a major version bump.