Skip to content

Conversation

LekoArts
Copy link
Contributor

Hello, Gatsby maintainer here 👋

While looking at the Gatsby plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Using Git blame I found this comment: #2652 (comment)
The APIs the plugin uses are safe to use on v2 and v3 of Gatsby :)

Thanks!

@LekoArts LekoArts requested a review from kamilogorek as a code owner April 12, 2021 10:04
@kamilogorek kamilogorek merged commit 5e8e996 into getsentry:master Apr 12, 2021
@kamilogorek
Copy link
Contributor

Makes perfect sense, thanks!

@LekoArts LekoArts deleted the patch-1 branch April 12, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants