Skip to content

fix: Replace performance.timeOrigin in favour of browserPerformanceTimeOrigin #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2021
Merged

fix: Replace performance.timeOrigin in favour of browserPerformanceTimeOrigin #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbcc673
fix(webvitals): Use browserPerformanceTimeOrigin for web vitals times…
dashed Apr 15, 2021
22d4071
coerce browserPerformanceTimeOrigin as a number since it'll always be…
dashed Apr 15, 2021
c016947
replace performance.timeOrigin with browserPerformanceTimeOrigin
dashed Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ember/addon/instance-initializers/sentry-performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as Sentry from '@sentry/browser';
import { Span, Transaction, Integration } from '@sentry/types';
import { EmberRunQueues } from '@ember/runloop/-private/types';
import { getActiveTransaction } from '..';
import { timestampWithMs } from '@sentry/utils';
import { browserPerformanceTimeOrigin, timestampWithMs } from '@sentry/utils';
import { macroCondition, isTesting, getOwnConfig } from '@embroider/macros';
import { EmberSentryConfig, OwnConfig } from '../types';

Expand Down Expand Up @@ -299,7 +299,7 @@ function _instrumentInitialLoad(config: EmberSentryConfig) {

// Split performance check in two so clearMarks still happens even if timeOrigin isn't available.
const HAS_PERFORMANCE_TIMING =
performance.measure && performance.getEntriesByName && performance.timeOrigin !== undefined;
performance.measure && performance.getEntriesByName && browserPerformanceTimeOrigin !== undefined;
if (!HAS_PERFORMANCE_TIMING) {
return;
}
Expand All @@ -309,7 +309,7 @@ function _instrumentInitialLoad(config: EmberSentryConfig) {
const measures = performance.getEntriesByName(measureName);
const measure = measures[0];

const startTimestamp = (measure.startTime + performance.timeOrigin) / 1000;
const startTimestamp = (measure.startTime + browserPerformanceTimeOrigin!) / 1000;
const endTimestamp = startTimestamp + measure.duration / 1000;

const transaction = getActiveTransaction();
Expand Down
4 changes: 2 additions & 2 deletions packages/tracing/src/browser/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export class MetricsInstrumentation {
return;
}

const timeOrigin = msToSec(performance.timeOrigin);
const timeOrigin = msToSec(browserPerformanceTimeOrigin as number);
const startTime = msToSec(entry.startTime as number);
logger.log('[Measurements] Adding LCP');
this._measurements['lcp'] = { value: metric.value };
Expand All @@ -253,7 +253,7 @@ export class MetricsInstrumentation {
return;
}

const timeOrigin = msToSec(performance.timeOrigin);
const timeOrigin = msToSec(browserPerformanceTimeOrigin as number);
const startTime = msToSec(entry.startTime as number);
logger.log('[Measurements] Adding FID');
this._measurements['fid'] = { value: metric.value };
Expand Down