ref(ember): Add type definitions for Ember #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we aren't running 'prepublishOnly' via Lerna, Ember-cli-typescript's precompile wasn't getting called. A pre and post publish call will temporarily create the definitions for publishing and remove them afterwards. This is required since .ts files can't be included in the app folder in Ember since they get merged as-is into a project file structure.
size-limit report
|
HazAT
approved these changes
May 12, 2021
It will. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we aren't running 'prepublishOnly' via Lerna, Ember-cli-typescript's precompile wasn't getting called. A pre and post publish call will temporarily create the definitions for publishing and remove them afterwards. This is required since .ts files can't be included in the app folder in Ember since they get merged as-is into a project file structure.
Note: Can someone from sdk confirm that prepublishOnly will get called before our release script is run?
Refs #3516