feat(eslint): Add new eslint rules #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update @typescript-eslint/naming-convention to use 'PascalCase' for typeLike declarations -> (class, interface, typeAlias, enum, typeParameter)
size-limit report
|
AbhiPrasad
force-pushed
the
abhi/eslint-updates
branch
from
79be62c
to
ea234b8
Compare
Add @typescript-eslint/explicit-member-accessibility rule to make sure class members declarations have explicit accessibility (public, private, protected).
AbhiPrasad
force-pushed
the
abhi/eslint-updates
branch
from
ea234b8
to
f650a15
Compare
HazAT
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some eslint rules I wanted to add based on Kamil's review comments I saw earlier.
feat(eslint): Add naming convention for typeLike - 6c5cd37
Update @typescript-eslint/naming-convention to use 'PascalCase'
for typeLike declarations -> (class, interface, typeAlias, enum, typeParameter)
feat(eslint): Make class member accessibility explicit - 79be62c
Add @typescript-eslint/explicit-member-accessibility rule to make
sure class members declarations have explicit accessibility (public,
private, protected).