test(nextjs): Add test for the metadata builder #3614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
requested review from
ahmedetefy and
kamilogorek
and removed request for
a team
size-limit report
|
AbhiPrasad
requested changes
May 28, 2021
There was a problem hiding this comment.
Hmm tbh I'm not the biggest fan of having indirection with test helpers that do assertions as it makes it harder to reason about what assertions are being called for a single test, but I'm fine with doing this for now as the test scope is relatively small.
Just left a few review comments for small fixes.
AbhiPrasad
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata builder has no tests atm; this PR adds them.