Skip to content

docs: raven-js migration user context example #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2021
Merged

docs: raven-js migration user context example #3824

merged 3 commits into from
Jul 22, 2021

Conversation

dtgay
Copy link
Contributor

@dtgay dtgay commented Jul 20, 2021

Modifies the MIGRATION.md file to add an example of converting setUserContext when migrating from raven-js to @sentry/browser.

@dtgay dtgay requested a review from kamilogorek as a code owner July 20, 2021 18:48
kamilogorek
kamilogorek suggested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use this variant to be more inline with what we had before + it looks better alongside setTag at the top

@dtgay @kamilogorek
Tweak setUser migration example to be more in line with old code
83c742b 
Co-authored-by: Kamil Ogórek <kamil@sentry.io>
@dtgay dtgay requested a review from kamilogorek July 21, 2021 15:49
@kamilogorek kamilogorek enabled auto-merge (squash) July 22, 2021 09:54
@kamilogorek kamilogorek disabled auto-merge July 22, 2021 09:57
@kamilogorek kamilogorek merged commit e5e8493 into getsentry:master Jul 22, 2021
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtgay @kamilogorek