Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Clear mocks in MetricsInstrumentation tests. #3944

Merged
merged 2 commits into from
Aug 31, 2021
Merged

fix(tests): Clear mocks in MetricsInstrumentation tests. #3944

merged 2 commits into from
Aug 31, 2021

Conversation

onurtemizkan
Copy link
Collaborator

Addressing: #3941 (review)
Adding jest.clearAllMocks(); also magically fixed the second sidenote 🤷‍♂️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2021 •
edited

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.6 KB (0%)
@sentry/browser - Webpack 22.61 KB (0%)
@sentry/react - Webpack 22.64 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.03 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 31, 2021 17:16
@AbhiPrasad AbhiPrasad merged commit 1d1b41c into master Aug 31, 2021
@AbhiPrasad AbhiPrasad deleted the onur/fix-tracing-metrics-tests branch August 31, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onurtemizkan @AbhiPrasad