Skip to content

fix(node): Disable autoSessionTracking if dsn undefined #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2021
Merged

fix(node): Disable autoSessionTracking if dsn undefined #3954

merged 3 commits into from
Sep 3, 2021

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 2, 2021 •
edited
Loading

Will help address situations like #3827, where user's have an open handle from the session flusher in tests.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.65 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.66 KB (0%)
@sentry/react - Webpack 22.7 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.08 KB (0%)

kamilogorek
kamilogorek suggested changes Sep 3, 2021
View reviewed changes
@AbhiPrasad AbhiPrasad merged commit d3ca7a8 into master Sep 3, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-auto-session-dsn branch September 3, 2021 21:25
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 3, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @kamilogorek