Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(nextjs): Only import BrowserTracing #4200

Closed
wants to merge 1 commit into from
Closed

ref(nextjs): Only import BrowserTracing #4200

wants to merge 1 commit into from

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Nov 30, 2021 •
edited

This is dependent on #4199

@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Nov 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.49 KB (+0.02% 🔺)
@sentry/browser - Webpack 23.37 KB (0%)
@sentry/react - Webpack 23.4 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.93 KB (+0.01% 🔺)

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Dec 1, 2021 •
edited

Ok so this doesn't work because the scenario seen in this rollup repl.

Since we spread the imports into an object, they are always included :/

We can only fix this in a breaking change 😢

@AbhiPrasad AbhiPrasad removed this from the Treeshaking / Bundle Size milestone Dec 1, 2021
@AbhiPrasad AbhiPrasad closed this Dec 1, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-nextjs-browser-tracing branch December 1, 2021 01:59
@AbhiPrasad AbhiPrasad mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AbhiPrasad