Skip to content

Conversation

onurtemizkan
Copy link
Collaborator

Part of: #4262

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

size-limit report

Path Base Size (e52faa4) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.77 KB 19.77 KB +0.02% 🔺
@sentry/browser - CDN Bundle (minified) 62.94 KB 62.94 KB +0.01% 🔺
@sentry/browser - Webpack 22.31 KB 22.31 KB 0%
@sentry/browser - Webpack - gzip = false 76.19 KB 76.19 KB 0%
@sentry/react - Webpack 22.34 KB 22.34 KB 0%
@sentry/nextjs Client - Webpack 46.48 KB 46.48 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.43 KB 28.43 KB +0.01% 🔺

trace_id: '12312012123120121231201212312012',
});

expect(eventData.spans?.length).toBeGreaterThan(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assert that navigation transactions won't have the same trace ID and parent span ID?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 adding the assertions to navigation tests at -> packages/integration-tests/suites/tracing/browsertracing/navigation/test.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also needed for the meta tests, to make sure that navigation transactions don't continue a transaction from the meta header.

// This is the `pageload` transaction
await getSentryTransactionRequest(page, url);

const navigationRequest = await getSentryTransactionRequest(page, `${url}#foo`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather us use the multiple transactions helper here.

I would also like to see some more assertions to show the differences between pageload and navigation transactions.

Copy link
Collaborator Author

@onurtemizkan onurtemizkan Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather us use the multiple transactions helper here.

My intention here is to initiate a navigation (to #foo) after the pageload transaction, so it's not possible to use the helper as it operates on a single URL for all requests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it - my mistake.

@AbhiPrasad AbhiPrasad merged commit 8c29ecf into master Jan 13, 2022
@AbhiPrasad AbhiPrasad deleted the onur/tests-browsertracing branch January 13, 2022 14:10
@AbhiPrasad AbhiPrasad added this to the Release Stability milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants