fix(vue): prevent after hook from starting new span #4438
Merged
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datbth
force-pushed
the
vue/fix_orphaned_tracing
branch
from
074fdb9 to
ac72ee4
Compare
AbhiPrasad
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Awesome, thanks for the PR!
We don't have amazing test coverage for Vue, I opened a issue to track it: #4440
I would leave the PR without tests for now, but help for tests are always appreciated!
packages/vue/src/tracing.ts
Outdated
| @@ -66,7 +66,9 @@ export const createTracingMixins = (options: TracingOptions): Mixins => { | |||
| continue; | |||
| } | |||
|
|
|||
| for (const internalHook of internalHooks) { | |||
| internalHooks.forEach((internalHook, hookType) => { | |||
There was a problem hiding this comment.
It is meant to retrieve hookType. Are you thinking checking internalHook === internalHooks[1] would suffice?
There was a problem hiding this comment.
I have discarded the change and updated to compare internalHook with internalHooks directly.
packages/vue/src/tracing.ts
Outdated
| @@ -66,7 +66,9 @@ export const createTracingMixins = (options: TracingOptions): Mixins => { | |||
| continue; | |||
| } | |||
|
|
|||
| for (const internalHook of internalHooks) { | |||
| internalHooks.forEach((internalHook, hookType) => { | |||
| const isBeforeHook = hookType === 0; | |||
There was a problem hiding this comment.
Any reason this need to be a variable? Only used once in the if statement - and I think the meaning is pretty clear without the need of a variable.
datbth
force-pushed
the
vue/fix_orphaned_tracing
branch
from
ac72ee4 to
093de9f
Compare
AbhiPrasad
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn lint) & (yarn test).Fix issue similar to #4427, where:
Notes:
ui.vue.activateI'm not able to find any existing tracing tests, so please tell me what I should do with the testing if necessary.