fix(integrations): Add default for ExtraErrorData's depth option
#4487
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that depth option is by default set to 3. That wouldn't happen if the user provided empty object as options. Fixes getsentry#4186
rchl
commented
Feb 2, 2022
| @@ -18,10 +18,18 @@ export class ExtraErrorData implements Integration { | |||
| */ | |||
| public name: string = ExtraErrorData.id; | |||
|
|
|||
| /** JSDoc */ | |||
There was a problem hiding this comment.
not sure what purpose does this have but I saw it the debug.ts's code
There was a problem hiding this comment.
It’s to get around writing doc strings. We can leave it like this.
This was referenced Feb 2, 2022
AbhiPrasad
approved these changes
Feb 2, 2022
| @@ -18,10 +18,18 @@ export class ExtraErrorData implements Integration { | |||
| */ | |||
| public name: string = ExtraErrorData.id; | |||
|
|
|||
| /** JSDoc */ | |||
There was a problem hiding this comment.
It’s to get around writing doc strings. We can leave it like this.
lobsterkatie
approved these changes
Feb 2, 2022
lobsterkatie
changed the title
ExtraErrorData's depth option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
ExtraErrorData'sdepthoption is by default set to 3. Currently, if the user provides an empty options object,depthgets set toundefined.Fixes #4186