Skip to content

ref(node): Increase stack parse test coverage #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

ref(node): Increase stack parse test coverage #4564

merged 2 commits into from
Feb 14, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 14, 2022

This PR:

  • Modifies the stack parse tests to test against the full expected result array
  • Adds an eval test

@timfish timfish mentioned this pull request Feb 14, 2022
Closed
15 tasks
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 14, 2022 14:55
@AbhiPrasad AbhiPrasad merged commit af9d08f into getsentry:master Feb 14, 2022
@timfish timfish deleted the test/node-stackparse branch February 14, 2022 16:05
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pre 7.0.0 Work
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad