Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete store endpoint code #4969

Merged
merged 2 commits into from
Apr 26, 2022
Merged

feat: Delete store endpoint code #4969

merged 2 commits into from
Apr 26, 2022

Conversation

AbhiPrasad
Copy link
Member

Delete all code related to store endpoint.

Built on top of work in #4967

Resolves https://getsentry.atlassian.net/browse/WEB-557

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 25, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.35 KB (-8.87% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.52 KB (-10.98% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.13 KB (-9.18% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.75 KB (-10.73% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.94 KB (-9.88% 🔽)
@sentry/browser - Webpack (minified) 72.5 KB (-11.28% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.98 KB (-9.89% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (-4.34% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.13 KB (-7.45% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.64 KB (-7.52% 🔽)

@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-delete-old-transports branch from 817a118 to 4e64c8d Compare April 25, 2022 14:46
@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-delete-store branch 2 times, most recently from f8d5392 to 88eac76 Compare April 25, 2022 15:50
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
lforst
lforst approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A general concern of mine is that the envelope file is completely untested.

packages/core/src/envelope.ts
/**
* Create an Envelope from an event.
*/
export function createEventEnvelope(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should def write tests for the functions in this file. Don't know whether this PR is the place for this tho. Wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should write tests - I can write up a ticket after this gets merged in.

@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-delete-old-transports branch from 5ad27a4 to dac51b7 Compare April 26, 2022 16:03
Base automatically changed from v7-abhi-delete-old-transports to 7.x April 26, 2022 16:41
@AbhiPrasad AbhiPrasad merged commit f0b6291 into 7.x Apr 26, 2022
@AbhiPrasad AbhiPrasad deleted the v7-abhi-delete-store branch April 26, 2022 17:48
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref: Delete store endpoint code (#4969)
0040b0f
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref: Delete store endpoint code (#4969)
299aeb3
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref: Delete store endpoint code (#4969)
22156f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @lforst