ref(core): Make event processing logs warnings #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
lforst and
lobsterkatie
and removed request for
a team
lforst
approved these changes
Apr 28, 2022
size-limit report 📦
|
|
Will wait till transport changes in #4998 to get merged to fix the baseclient tests (easier to resolve conflicts then). |
Yup, good catch! |
AbhiPrasad
force-pushed
the
v7-abhi-warn-errors
branch
from
526c671
to
4f7f1d4
Compare
It can be confusing to users why event processing errors log out as errors. Let's bump this down to warnings instead - which better represent how actionable most of these thrown errors are.
AbhiPrasad
force-pushed
the
v7-abhi-warn-errors
branch
from
4f7f1d4
to
1aca7c5
Compare
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
It can be confusing to users why event processing errors log out as errors. Let's bump this down to warnings instead - which better represent how actionable most of these thrown errors are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be confusing to users why event processing errors log out as errors. Let's bump this down to warnings instead - which better represent how actionable most of these thrown errors are.
Based on feedback in #3939