Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Delete unneeded SDK_NAME #5040

Merged
merged 1 commit into from
May 5, 2022
Merged

ref: Delete unneeded SDK_NAME #5040

merged 1 commit into from
May 5, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented May 5, 2022

Removes SDK_NAME export from from @sentry/browser, @sentry/node, @sentry/tracing and @sentry/vue packages.

This const contained the name of the sdk in the form of 'sentry.javascript.browser' which was used internally but is now unused because we define the sdk name in the clients directly.

Ref: https://getsentry.atlassian.net/browse/WEB-823

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.72 KB (-7.04% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.51 KB (-9.45% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.53 KB (-7.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.69 KB (-9.11% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.2 KB (-17.38% 🔽)
@sentry/browser - Webpack (minified) 62.07 KB (-24.05% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.22 KB (-17.43% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.9 KB (-10.74% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.5 KB (-6.06% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.08 KB (-5.74% 🔽)

@lforst lforst marked this pull request as ready for review May 5, 2022 10:14
@lforst lforst requested review from AbhiPrasad and Lms24 May 5, 2022 10:15
@lforst lforst merged commit 9782d69 into 7.x May 5, 2022
@lforst lforst deleted the lforst-delete-sdk-name branch May 5, 2022 11:57
@lforst lforst added this to the 7.0.0 milestone May 5, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants