ref(utils): Clean up dangerous type casts in object helper file #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
force-pushed
the
lforst-object-cleanup
branch
from
e38d12f
to
78f733e
Compare
size-limit report 📦
|
lforst
force-pushed
the
lforst-object-cleanup
branch
from
78f733e
to
d8023f9
Compare
AbhiPrasad
approved these changes
May 6, 2022
packages/utils/src/object.ts
Outdated
| [key: string]: unknown; | ||
| }; | ||
|
|
||
| export function convertToPlainObject<V extends unknown>(value: V): Record<string, unknown> | V { |
There was a problem hiding this comment.
we can maybe type this return values more strongly (and union type the various returns)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to understand what
convertToPlainObjectdoes, I noticed that it had some pretty dangerous type signatures. This PR tries to clean that up a bit.This PR intends not change any behaviour.