ref(dev): Split up top-level yarn clean script
#5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
May 13, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This splits the repo-level `yarn clean` command, which currently leaves the repo in a broken state (build artifacts deleted, and unable to be rebuilt because package-level `node_modules` folders - though not the top `node_modules` folder - have also been deleted), into a number of new, more focused commands. In the `clean:deps` command, it now deletes _all_ `node_modules` folders (repo- and package-level) and reinstalls dependencies, so that the repo is no longer broken after running it. The new commands: ``` // Meant to be a useful default for day-to-day use "clean": "run-p clean:build clean:caches" // Runs all package-level clean commands, which delete build and testing artifacts "clean:build": "lerna run --parallel clean" // TODO: Are there other caches we should add here? "clean:caches": "yarn rimraf eslintcache && yarn jest --clearCache" // Nuke all node modules and reinstall dependencies "clean:deps": "lerna clean --yes && rm -rf node_modules && yarn" // insert "Clean all the things!" meme here "clean:all": "run-p clean:build clean:caches clean:deps" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the repo-level
yarn cleancommand, which currently leaves the repo in a broken state (build artifacts deleted, and unable to be rebuilt because package-levelnode_modulesfolders - though not the topnode_modulesfolder - have also been deleted), into a number of new, more focused commands. In theclean:depscommand, it now deletes allnode_modulesfolders (repo- and package-level) and reinstalls dependencies, so that the repo is no longer broken after running it. The new commands: