Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Record transaction name source when name set directly #5396

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jul 8, 2022

This adds transaction name source to transaction metadata in various situations in which the name is set directly: starting a manual transaction, assigning to the name property of a transaction, calling a transaction's setName method, and changing the name using beforeNavigate.

In order to distinguish manually-created transactions from automatically-created ones, all internal uses of startTransaction have been changed so that they are happening directly on the hub, rather than through the top-level Sentry.startTransaction() wrapper.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.36 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 59.89 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.95 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 52.8 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.71 KB (0%)
@sentry/browser - Webpack (minified) 64.15 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.73 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.02 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.82 KB (+0.38% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.06 KB (+0.27% 🔺)

packages/hub/src/exports.ts Show resolved Hide resolved
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 8, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-add-transaction-name-source-in-manual-instrumentation branch from 32e90dd to a478689 Compare July 8, 2022 19:25
@lobsterkatie lobsterkatie force-pushed the kmclb-add-transaction-name-source-in-manual-instrumentation branch from 898dd30 to f5a8337 Compare July 8, 2022 20:02
@lobsterkatie lobsterkatie merged commit 8b4ab49 into master Jul 8, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-transaction-name-source-in-manual-instrumentation branch July 8, 2022 20:23
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 8, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants