Skip to content

docs(replay): Add CDN bundle instructions to README #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 6, 2022

This PR adds a subsection about CDN bundle installation and usage.

The only thing that's different in this doc compared to a normal integration CDN bundle doc on Sentry docs is that I can't specify the integrity attribute in the script tag because we can't automatically get the correct checksum in the Readme. I opted to leave it out and add a sentence that links people to our CDN bundle checksum table.

internal ref: https://www.notion.so/sentry/Checklist-Closed-Beta-Cohort-2-db73b0edc8e84fd28e6fc8253b79469f

@Lms24 Lms24 requested review from mydea, ryan953 and jas-kas December 6, 2022 10:13
@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Dec 6, 2022
@Lms24 Lms24 self-assigned this Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.67 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.94 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.49 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.26 KB (0%)
@sentry/browser - Webpack (minified) 66.24 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.29 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.14 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.52 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.96 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.73 KB (-0.52% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.82 KB (-0.19% 🔽)

@Lms24 Lms24 force-pushed the lms-replay-readme-cdn branch from 240dbab to 6b94b74 Compare December 6, 2022 10:30
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Lms24
Copy link
Member Author

Lms24 commented Dec 6, 2022

Merging this now to get it into the release. @reviewers, if you have comments/suggestions, we can open a follow-up PR and address them there

@Lms24 Lms24 merged commit 594c7e8 into master Dec 6, 2022
@Lms24 Lms24 deleted the lms-replay-readme-cdn branch December 6, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants