Skip to content

ref(replay): Allow timestamp to be passed as an argument to sendReplayRequest #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2023
Merged

ref(replay): Allow timestamp to be passed as an argument to sendReplayRequest #6696

merged 2 commits into from
Jan 11, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 9, 2023

This will be needed when attempting to send a replay request at a different time (e.g. after a reload).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.04 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (0%)

billyvg
billyvg commented Jan 9, 2023
View reviewed changes
@billyvg billyvg marked this pull request as ready for review January 9, 2023 20:04
@billyvg billyvg requested a review from mydea January 9, 2023 20:04
This was referenced Jan 10, 2023
Merged
Merged
Closed
@billyvg
ref(replay): Allow timestamp to be passed as an argument to `sendRe…
c970be1 
…playRequest`

This will be needed when attempting to send a replay request at a different time (e.g. after a reload).
@billyvg
Update packages/replay/src/replay.ts
d0a164e
@billyvg billyvg force-pushed the ref-replay-allow-timestamp-as-argument-send-request branch from dec280a to d0a164e Compare January 11, 2023 14:42
@billyvg billyvg enabled auto-merge (squash) January 11, 2023 14:45
@billyvg billyvg merged commit 9ec436b into master Jan 11, 2023
@billyvg billyvg deleted the ref-replay-allow-timestamp-as-argument-send-request branch January 11, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @mydea