build: Remove @sentry-internal/sdk/no-async-await rule
#6797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-no-async-await-remove
branch
from
9316b99 to
8b37bca
Compare
mydea
approved these changes
Jan 16, 2023
AbhiPrasad
force-pushed
the
abhi-no-async-await-remove
branch
from
fc3877d to
e6afe75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6789
Since we are optimizing for es6 bundles, we can remove the
@sentry-internal/sdk/no-async-awaitrule. Usingasync awaitwill increase bundle size for es5 bundles, but presents us the opportunity to reduce it for es6 bundles.