Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update custom transport migration docs #7143

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

AbhiPrasad
Copy link
Member

As per feedback in #7112, just forward along all of the options as it reduces user need to understand what they do.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and Lms24 and removed request for a team February 10, 2023 14:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR 17c3132 71.86 ms 95.19 ms +23.33 ms +32.47 % 129.97 ms +58.11 ms +80.88 %
Previous 274f489 69.12 ms 96.76 ms +27.64 ms +39.98 % 132.72 ms +63.60 ms +92.01 %
CLS This PR 17c3132 0.06 ms 0.06 ms -0.00 ms -0.00 % 0.06 ms +0.00 ms +0.06 %
Previous 274f489 0.06 ms 0.06 ms -0.00 ms -0.39 % 0.06 ms -0.00 ms -0.62 %
CPU This PR 17c3132 17.13 % 16.89 % -0.25 pp -1.44 % 29.76 % +12.63 pp +73.72 %
Previous 274f489 13.38 % 13.55 % +0.17 pp +1.25 % 24.94 % +11.56 pp +86.44 %
JS heap avg This PR 17c3132 1.94 MB 1.99 MB +51.48 kB +2.65 % 3.02 MB +1.08 MB +55.36 %
Previous 274f489 1.94 MB 2 MB +53.31 kB +2.74 % 3.02 MB +1.08 MB +55.57 %
JS heap max This PR 17c3132 2.3 MB 2.57 MB +267.54 kB +11.63 % 4.51 MB +2.2 MB +95.81 %
Previous 274f489 2.3 MB 2.55 MB +248.56 kB +10.79 % 4.5 MB +2.2 MB +95.46 %
netTx This PR 17c3132 0 B 0 B 0 B n/a 2.58 kB +2.58 kB n/a
Previous 274f489 0 B 0 B 0 B n/a 2.56 kB +2.56 kB n/a
netRx This PR 17c3132 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous 274f489 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR 17c3132 0 0 0 n/a 1 +1 n/a
Previous 274f489 0 0 0 n/a 1 +1 n/a
netTime This PR 17c3132 0.00 ms 0.00 ms 0.00 ms n/a 103.38 ms +103.38 ms n/a
Previous 274f489 0.00 ms 0.00 ms 0.00 ms n/a 116.60 ms +116.60 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
274f489+63.60 ms-0.00 ms+11.56 pp+1.08 MB+2.2 MB+2.56 kB+41 B+1+116.60 ms
4827b60+58.67 ms+0.00 ms+18.38 pp+1.07 MB+2.22 MB+2.6 kB+41 B+1+91.21 ms
c3806eb+79.85 ms-0.00 ms+12.10 pp+1.05 MB+2.16 MB+2.54 kB+41 B+1+93.58 ms
b49d9f7+52.79 ms-0.00 ms+15.46 pp+1.07 MB+2.21 MB+2.59 kB+41 B+1+70.48 ms
7e57cb7+47.89 ms+0.00 ms+10.59 pp+1.09 MB+2.21 MB+2.59 kB+41 B+1+72.93 ms
538c3a6+63.63 ms+0.00 ms+14.14 pp+1.07 MB+2.16 MB+2.6 kB+41 B+1+112.08 ms
fc7b716+52.44 ms+0.00 ms+14.74 pp+1.09 MB+2.21 MB+2.68 kB+41 B+1+89.64 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 10 Feb 2023 14:56:47 GMT

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes way more sense :D not sure why I wrote it this way back then

@AbhiPrasad AbhiPrasad merged commit df73015 into develop Feb 10, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-custom-transport-migration-docs branch February 10, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants