Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce raven.min.js filesize #721

Merged
merged 3 commits into from
Sep 12, 2016
Merged

Reduce raven.min.js filesize #721

merged 3 commits into from
Sep 12, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Sep 3, 2016

Two major changes:

  • Inlines all of src/utils.js into src/raven.js (for better minification)
  • Aliases window and document into local vars for better minification

cc @mattrobenolt @macqueen


This change is Reviewable

@benvinegar
Copy link
Contributor Author

benvinegar commented Sep 3, 2016

Impact of these changes:

Type master less-bytes (PR) Change (%)
minified 21.7 kB 20.9 kB -3.7%
minified + gzip 8.52 kB 8.32 kB -2.3%

@benvinegar benvinegar changed the title Reduce raven.min.js filesize ... Reduce raven.min.js filesize Sep 6, 2016
@macqueen
Copy link

macqueen commented Sep 7, 2016

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@benvinegar
Copy link
Contributor Author

@mattrobenolt – would like to get your thoughts before I merge

@mattrobenolt
Copy link
Contributor

@benvinegar benvinegar merged commit 203dd7f into master Sep 12, 2016
@benvinegar benvinegar deleted the less-bytes branch September 12, 2016 18:23
@benvinegar benvinegar mentioned this pull request Oct 27, 2016
denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
* Inline src/utils.js into src/raven.js for better compression
* Alias stuff to save bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants