Skip to content

fix(core): Ensure ignoreErrors only applies to error events #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix(core): Ensure ignoreErrors only applies to error events #7573

merged 1 commit into from
Mar 23, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 22, 2023

Noticed that actually currently we filter any type of event here.

We should handle transactions separately (TBD).

@mydea mydea requested review from Lms24 and AbhiPrasad March 22, 2023 16:17
@mydea mydea self-assigned this Mar 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 71.66 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.9 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.3 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.36 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.49 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.04 KB (+0.01% 🔺)

@mydea mydea force-pushed the fn/ignore-errors branch from f23755e to 538285a Compare March 23, 2023 07:55
@mydea mydea changed the title fix: Ensure ignoreErrors only applies to error events fix(core): Ensure ignoreErrors only applies to error events Mar 23, 2023
@mydea mydea added the Package: core Issues related to the Sentry Core SDK label Mar 23, 2023
@mydea mydea enabled auto-merge (squash) March 23, 2023 07:55
@mydea mydea merged commit 0a1a567 into develop Mar 23, 2023
@mydea mydea deleted the fn/ignore-errors branch March 23, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
Package: core Issues related to the Sentry Core SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @AbhiPrasad