Skip to content

Retry-After is returned in seconds, not ms #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

Retry-After is returned in seconds, not ms #862

merged 1 commit into from
Feb 23, 2017

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Feb 22, 2017 •
edited
Loading

Fixes #860

cc @bretthoerner @getsentry/javascript

@LewisJEllis
Copy link
Contributor

LGTM. I also wanted to be sure that sentry server actually follows the header convention and does seconds; you probably know it does off hand but I found that code path in the rate limiting stuff and verified.

@benvinegar
Copy link
Contributor Author

@mattrobenolt – can you confirm we return seconds?

@bretthoerner
Copy link

bretthoerner commented Feb 23, 2017 via email

@benvinegar benvinegar merged commit 4b05748 into master Feb 23, 2017
@benvinegar benvinegar deleted the fix-retry-after branch February 23, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bretthoerner bretthoerner bretthoerner approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benvinegar @LewisJEllis @bretthoerner