Skip to content

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar requested a review from LewisJEllis March 20, 2017 06:28
Copy link
Contributor

@LewisJEllis LewisJEllis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks roughly good, but lets rebase on master after 3.12.2 lands and then have another look before merging?

@@ -1,4 +1,4 @@
/*! Raven.js 3.12.1 (3600a05) | github.com/getsentry/raven-js */
/*! Raven.js 3.12.1 (e88fbea) | github.com/getsentry/raven-js */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this say 3.13.0?

@benvinegar
Copy link
Contributor Author

@LewisJEllis – can you quickly look again?

@benvinegar
Copy link
Contributor Author

Note the 3.12.2 dist changes didn't get propagated to master – I did all that on a separate branch (branching from 3.12.1, not HEAD@master).

@benvinegar benvinegar merged commit a721c9f into master Mar 21, 2017
@benvinegar benvinegar deleted the release-3.13.0 branch March 21, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants